GerbilSoft/rom-properties
1
Fork 0
mirror of https://github.com/GerbilSoft/rom-properties.git synced 2025-06-18 11:35:38 -04:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[librpfile] VectorFile: Move MAX_SIZE from the class definition to the .cpp file.

Browse Source 
MSVC exports it from the DLL if it's in the class definition for some
reason. We don't want it exported.
This commit is contained in:
David Korth 2025-04-19 21:57:03 -04:00
parent 0214ec25ec
commit 8073d9d826
2 changed files with 119 additions and 119 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/librpfile/VectorFile.cpp
View File

@ -14,6 +14,9 @@ using std::string;
namespace LibRpFile {
// 128 MB *should* be a reasonable maximum...
static constexpr off64_t MAX_SIZE = 128U*1024U*1024U;
/**
* Open an IRpFile backed by an std::vector.
* The resulting IRpFile is writable.

235
src/librpfile/VectorFile.hpp
View File

@ -17,142 +17,139 @@ namespace LibRpFile {
class RP_LIBROMDATA_PUBLIC VectorFile final : public IRpFile
{
public:
/**
* Open an IRpFile backed by an std::vector.
* The resulting IRpFile is writable.
*/
VectorFile();
public:
~VectorFile() final;
public:
/**
* Open an IRpFile backed by an std::vector.
* The resulting IRpFile is writable.
*/
VectorFile();
public:
~VectorFile() final;
private:
typedef IRpFile super;
RP_DISABLE_COPY(VectorFile)
public:
// 128 MB *should* be a reasonable maximum...
static constexpr off64_t MAX_SIZE = 128U*1024U*1024U;
private:
typedef IRpFile super;
RP_DISABLE_COPY(VectorFile)
public:
/**
* Is the file open?
* This usually only returns false if an error occurred.
* @return True if the file is open; false if it isn't.
*/
bool isOpen(void) const final
{
// VectorFile is always open.
return true;
}
public:
/**
* Is the file open?
* This usually only returns false if an error occurred.
* @return True if the file is open; false if it isn't.
*/
bool isOpen(void) const final
{
// VectorFile is always open.
return true;
}
/**
* Close the file.
*/
void close(void) final
{
// Not really useful...
}
/**
* Close the file.
*/
void close(void) final
{
// Not really useful...
}
/**
* Read data from the file.
* @param ptr Output data buffer.
* @param size Amount of data to read, in bytes.
* @return Number of bytes read.
*/
ATTR_ACCESS_SIZE(write_only, 2, 3)
size_t read(void *ptr, size_t size) final;
/**
* Read data from the file.
* @param ptr Output data buffer.
* @param size Amount of data to read, in bytes.
* @return Number of bytes read.
*/
ATTR_ACCESS_SIZE(write_only, 2, 3)
size_t read(void *ptr, size_t size) final;
/**
* Write data to the file.
* @param ptr Input data buffer.
* @param size Amount of data to read, in bytes.
* @return Number of bytes written.
*/
ATTR_ACCESS_SIZE(read_only, 2, 3)
size_t write(const void *ptr, size_t size) final;
/**
* Write data to the file.
* @param ptr Input data buffer.
* @param size Amount of data to read, in bytes.
* @return Number of bytes written.
*/
ATTR_ACCESS_SIZE(read_only, 2, 3)
size_t write(const void *ptr, size_t size) final;
/**
* Set the file position.
* @param pos File position.
* @return 0 on success; -1 on error.
*/
int seek(off64_t pos) final;
/**
* Set the file position.
* @param pos File position.
* @return 0 on success; -1 on error.
*/
int seek(off64_t pos) final;
/**
* Get the file position.
* @return File position, or -1 on error.
*/
off64_t tell(void) final
{
return static_cast<off64_t>(m_pos);
}
/**
* Get the file position.
* @return File position, or -1 on error.
*/
off64_t tell(void) final
{
return static_cast<off64_t>(m_pos);
}
/**
* Truncate the file.
* @param size New size. (default is 0)
* @return 0 on success; -1 on error.
*/
int truncate(off64_t size = 0) final;
/**
* Truncate the file.
* @param size New size. (default is 0)
* @return 0 on success; -1 on error.
*/
int truncate(off64_t size = 0) final;
/**
* Flush buffers.
* This operation only makes sense on writable files.
* @return 0 on success; negative POSIX error code on error.
*/
int flush(void) final
{
// Ignore flush operations, since VectorFile is entirely in memory.
return 0;
}
/**
* Flush buffers.
* This operation only makes sense on writable files.
* @return 0 on success; negative POSIX error code on error.
*/
int flush(void) final
{
// Ignore flush operations, since VectorFile is entirely in memory.
return 0;
}
public:
/** File properties **/
public:
/** File properties **/
/**
* Get the file size.
* @return File size, or negative on error.
*/
off64_t size(void) final
{
return m_pVector->size();
}
/**
* Get the file size.
* @return File size, or negative on error.
*/
off64_t size(void) final
{
return m_pVector->size();
}
public:
/** Extra functions **/
public:
/** Extra functions **/
/**
* Make the file writable.
* @return 0 on success; negative POSIX error code on error.
*/
int makeWritable(void) final
{
return 0;
}
/**
* Make the file writable.
* @return 0 on success; negative POSIX error code on error.
*/
int makeWritable(void) final
{
return 0;
}
public:
/** VectorFile-specific functions **/
public:
/** VectorFile-specific functions **/
/**
* Get the underlying std::vector.
* @return std::vector.
*/
std::vector<uint8_t> &vector(void)
{
return *m_pVector;
}
/**
* Get the underlying std::vector.
* @return std::vector.
*/
std::vector<uint8_t> &vector(void)
{
return *m_pVector;
}
/**
* Get the underlying std::vector.
* @return std::vector.
*/
const std::vector<uint8_t> &vector(void) const
{
return *m_pVector;
}
/**
* Get the underlying std::vector.
* @return std::vector.
*/
const std::vector<uint8_t> &vector(void) const
{
return *m_pVector;
}
protected:
std::vector<uint8_t> *m_pVector; // NOTE: Needs to be ptr to prevent DLL linkage issues.
size_t m_pos; // Current position
protected:
std::vector<uint8_t> *m_pVector; // NOTE: Needs to be ptr to prevent DLL linkage issues.
size_t m_pos; // Current position
};
typedef std::shared_ptr<VectorFile> VectorFilePtr;