GerbilSoft/rom-properties
1
Fork 0
mirror of https://github.com/GerbilSoft/rom-properties.git synced 2025-06-18 19:45:41 -04:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[librptexture] ICOPrivate::loadImage_WinVista_PNG(): Use res.pBestIcon->nID instead of res.id.

Browse Source 
res.id may have accidentally worked because it was set to -1, but it's
the ID of the RT_GROUP_ICON, not the RT_ICON.
This commit is contained in:
David Korth 2025-06-12 21:11:41 -04:00
parent 783d384b04
commit 704a5eead5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/librptexture/fileformat/ICO.cpp
View File

@ -891,7 +891,7 @@ rp_image_const_ptr ICOPrivate::loadImage_WinVista_PNG(void)
if (rt != 0) { if (rt != 0) {
// Load the PNG from a resource. // Load the PNG from a resource.
const auto &res = *(dir.res); const auto &res = *(dir.res);
f_png = res.resReader->open(rt, res.id, res.lang); f_png = res.resReader->open(rt, le16_to_cpu(res.pBestIcon->nID), res.lang);
} else { } else {
// NOTE: PartitionFile only supports IDiscReader, so we'll need to // NOTE: PartitionFile only supports IDiscReader, so we'll need to
// create a dummy DiscReader object. // create a dummy DiscReader object.