GerbilSoft/rom-properties
1
Fork 0
mirror of https://github.com/GerbilSoft/rom-properties.git synced 2025-06-18 11:35:38 -04:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[cmake] CheckIfuncSupport.cmake: Don't check for NOT DEFINED HAVE_IFUNC.

Browse Source 
Otherwise, if I add -fsanitize in a later run, IFUNC will remain enabled,
resulting in SIGSEGV.

Also, add checks for CFLAGS/CXXFLAGS in specific build types, similar to
libromdata.
This commit is contained in:
David Korth 2025-01-25 14:34:52 -05:00
parent bf4de23c2b
commit 47296cfc9d
1 changed files with 30 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
cmake/macros/CheckIfuncSupport.cmake
View File

@ -2,40 +2,40 @@
# Requires ELF. Currently supported by gcc, but not clang.
FUNCTION(CHECK_IFUNC_SUPPORT)
IF(NOT DEFINED HAVE_IFUNC)
# NOTE: ${CMAKE_MODULE_PATH} has two directories, macros/ and libs/,
# so we have to configure this manually.
SET(IFUNC_SOURCE_PATH "${CMAKE_SOURCE_DIR}/cmake/macros")
# NOTE: ${CMAKE_MODULE_PATH} has two directories, macros/ and libs/,
# so we have to configure this manually.
SET(IFUNC_SOURCE_PATH "${CMAKE_SOURCE_DIR}/cmake/macros")
# NOTE: If -fsanitize is specified, disable IFUNC.
# Otherwise, SIGSEGV will happen.
IF(CMAKE_C_FLAGS MATCHES -fsanitize OR CMAKE_CXX_FLAGS MATCHES -fsanitize)
SET(IS_SANITIZE 1)
ENDIF()
# NOTE: If -fsanitize is specified, disable IFUNC.
# Otherwise, SIGSEGV will happen.
IF(CMAKE_C_FLAGS MATCHES "-fsanitize" OR CMAKE_CXX_FLAGS MATCHES "-fsanitize")
SET(IS_SANITIZE 1)
ELSEIF(CMAKE_C_FLAGS_${BUILD_TYPE_UCASE} MATCHES "-fsanitize" OR CMAKE_CXX_FLAGS_${BUILD_TYPE_UCASE} MATCHES "-fsanitize")
SET(IS_SANITIZE 1)
ENDIF()
# Check for IFUNC support.
MESSAGE(STATUS "Checking if IFUNC is supported")
IF(WIN32 OR APPLE)
# No IFUNC for Windows or Mac OS X.
# Shortcut here to avoid needing a cross-compiled test program.
# Check for IFUNC support.
MESSAGE(STATUS "Checking if IFUNC is supported")
IF(WIN32 OR APPLE)
# No IFUNC for Windows or Mac OS X.
# Shortcut here to avoid needing a cross-compiled test program.
MESSAGE(STATUS "Checking if IFUNC is supported - no")
SET(TMP_HAVE_IFUNC FALSE)
ELSEIF(IS_SANITIZE)
MESSAGE(STATUS "Checking if IFUNC is supported - disabled due to -fsanitize")
SET(TMP_HAVE_IFUNC FALSE)
ELSE()
TRY_RUN(TMP_HAVE_IFUNC_RUN TMP_HAVE_IFUNC_COMPILE
"${CMAKE_BINARY_DIR}"
"${IFUNC_SOURCE_PATH}/IfuncTest.c")
IF(TMP_HAVE_IFUNC_COMPILE AND (TMP_HAVE_IFUNC_RUN EQUAL 0))
MESSAGE(STATUS "Checking if IFUNC is supported - yes")
SET(TMP_HAVE_IFUNC TRUE)
ELSE()
MESSAGE(STATUS "Checking if IFUNC is supported - no")
SET(TMP_HAVE_IFUNC FALSE)
ELSEIF(IS_SANITIZE)
MESSAGE(STATUS "Checking if IFUNC is supported - disabled due to -fsanitize")
SET(TMP_HAVE_IFUNC FALSE)
ELSE()
TRY_RUN(TMP_HAVE_IFUNC_RUN TMP_HAVE_IFUNC_COMPILE
"${CMAKE_BINARY_DIR}"
"${IFUNC_SOURCE_PATH}/IfuncTest.c")
IF(TMP_HAVE_IFUNC_COMPILE AND (TMP_HAVE_IFUNC_RUN EQUAL 0))
MESSAGE(STATUS "Checking if IFUNC is supported - yes")
SET(TMP_HAVE_IFUNC TRUE)
ELSE()
MESSAGE(STATUS "Checking if IFUNC is supported - no")
SET(TMP_HAVE_IFUNC FALSE)
ENDIF()
ENDIF()
SET(HAVE_IFUNC ${TMP_HAVE_IFUNC} CACHE INTERNAL "Is IFUNC supported?")
ENDIF()
SET(HAVE_IFUNC ${TMP_HAVE_IFUNC} CACHE INTERNAL "Is IFUNC supported?")
ENDFUNCTION(CHECK_IFUNC_SUPPORT)