GerbilSoft/rom-properties
1
Fork 0
mirror of https://github.com/GerbilSoft/rom-properties.git synced 2025-06-18 11:35:38 -04:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[libpng] Disable /guard:cf in MSVC builds for now.
Some checks failed
Codecov / run (push) Has been cancelled
Details
CodeQL / Analyze (cpp) (push) Has been cancelled
Details

Browse Source 
This is what was causing the libpng crash in png_longjmp() on
Windows 10 in MSVC 2022 release builds.

See #451: libpng errors crash due to libpng setjmp/longjmp (Windows 10, release builds only)
Reported by @Masamune3210.
This commit is contained in:
David Korth 2025-05-26 11:11:51 -04:00
parent 55fac18b76
commit 407fb36461
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
extlib/libpng/CMakeLists.txt vendored
View File

@ -689,6 +689,14 @@ if(MSVC OR (WIN32 AND (CMAKE_C_COMPILER_ID MATCHES "Clang")))
add_definitions(-D_CRT_SECURE_NO_DEPRECATE)
endif()
# rom-properties: FIXME: "/guard:cf" causes png_longjmp() to crash
# in MSVC 2022 Release builds on Windows 10.
IF(MSVC)
FOREACH(_var CMAKE_C_FLAGS CMAKE_CXX_FLAGS CMAKE_EXE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS CMAKE_MODULE_LINKER_FLAGS)
STRING(REPLACE "/guard:cf" "" ${_var} "${${${_var}}}")
ENDFOREACH(_var)
ENDIF(MSVC)
# rom-properties: Add -DPNG_DEBUG=0 in debug builds.
IF(0)
if(PNG_DEBUG)