GerbilSoft/rom-properties
1
Fork 0
mirror of https://github.com/GerbilSoft/rom-properties.git synced 2025-06-18 19:45:41 -04:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

FIXME: On Windows 7, UTF-8 console output can randomly crash the program.
Some checks failed
Codecov / run (push) Has been cancelled
Details
CodeQL / Analyze (cpp) (push) Has been cancelled
Details

Browse Source 
Not sure why. It's probably a limitation of the older console.

It works on Windows 10. (tested on 1809)

TODO: Does it work on Windows 8 or 8.1?
This commit is contained in:
David Korth 2025-04-21 23:36:12 -04:00
parent 602165f822
commit 18d005bb2b
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/librpbase/tests/gtest_init.cpp
View File

@ -190,7 +190,11 @@ int RP_C_API _tmain(int argc, TCHAR *argv[])
// Enable UTF-8 console output.
// Tested on Windows XP (fails) and Windows 7 (works).
// TODO: Does it work on Windows Vista?
if (IsWindowsVistaOrGreater()) {
// FIXME: On Windows 7, if locale is set to Spanish (es_ES), running
// `rpcli rpcli.exe` causes a random crash halfway through printing,
// if we set the console output CP to UTF-8.
// TODO: Verify if that happens on Windows 8 or 8.1.
if (IsWindows10OrGreater()) {
old_console_output_cp = GetConsoleOutputCP();
atexit(RestoreConsoleOutputCP);
SetConsoleOutputCP(CP_UTF8);

6
src/rpcli/rpcli.cpp
View File

@ -658,7 +658,11 @@ int RP_C_API _tmain(int argc, TCHAR *argv[])
// Enable UTF-8 console output.
// Tested on Windows XP (fails) and Windows 7 (works).
// TODO: Does it work on Windows Vista?
if (IsWindowsVistaOrGreater()) {
// FIXME: On Windows 7, if locale is set to Spanish (es_ES), running
// `rpcli rpcli.exe` causes a random crash halfway through printing,
// if we set the console output CP to UTF-8.
// TODO: Verify if that happens on Windows 8 or 8.1.
if (IsWindows10OrGreater()) {
old_console_output_cp = GetConsoleOutputCP();
atexit(RestoreConsoleOutputCP);
SetConsoleOutputCP(CP_UTF8);