GerbilSoft/rom-properties
1
Fork 0
mirror of https://github.com/GerbilSoft/rom-properties.git synced 2025-06-18 19:45:41 -04:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[librpfile] RpFilePrivate: Remove the unnecessary const std::string& constructor.

Browse Source 
We're just calling strdup() anyway, so we only need the `const char*`
constructor, since we can pass filename.c_str() from the public class
constructor to the private class constructor.
This commit is contained in:
David Korth 2023-07-23 18:31:11 -04:00
parent e4f0df9f01
commit 0eb09f467c
3 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/librpfile/RpFile_p.hpp
View File

@ -76,13 +76,6 @@ class RpFilePrivate
assert(filename != nullptr); assert(filename != nullptr);
this->filename = strdup(filename); this->filename = strdup(filename);
} }
RpFilePrivate(RpFile *q, const string &filename, RpFile::FileMode mode)
: q_ptr(q), file(INVALID_HANDLE_VALUE)
, mode(mode), gzfd(nullptr), gzsz(-1), devInfo(nullptr)
{
assert(!filename.empty());
this->filename = strdup(filename.c_str());
}
~RpFilePrivate(); ~RpFilePrivate();
private: private:

2
src/librpfile/RpFile_stdio.cpp
View File

@ -235,7 +235,7 @@ RpFile::RpFile(const char *filename, FileMode mode)
*/ */
RpFile::RpFile(const string &filename, FileMode mode) RpFile::RpFile(const string &filename, FileMode mode)
: super() : super()
, d_ptr(new RpFilePrivate(this, filename, mode)) , d_ptr(new RpFilePrivate(this, filename.c_str(), mode))
{ {
init(); init();
} }

2
src/librpfile/win32/RpFile_win32.cpp
View File

@ -295,7 +295,7 @@ RpFile::RpFile(const char *filename, FileMode mode)
*/ */
RpFile::RpFile(const string &filename, FileMode mode) RpFile::RpFile(const string &filename, FileMode mode)
: super() : super()
, d_ptr(new RpFilePrivate(this, filename, mode)) , d_ptr(new RpFilePrivate(this, filename.c_str(), mode))
{ {
init(); init();
} }